8000 7FFF fix: notice about deprecated option replacement by sipayRT · Pull Request #957 · gemini-testing/gemini · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Sep 21, 2022. It is now read-only.

fix: notice about deprecated option replacement - #957

Merged
sipayRT merged 1 commit into
masterfrom
sipayRT.deprecatedOptions
Jan 30, 2019
Merged

sipayRT merged 1 commit into
masterfrom
sipayRT.deprecatedOptions

Conversation

@sipayRT
@sipayRT sipayRT commented Jan 28, 2019
Copy link
Copy Markdown
Member

fix #956

@sipayRT
sipayRT commented Jan 28, 2019
Copy link
Copy Markdown
Member Author

//cc @DudaGod @rostik404

@DudaGod DudaGod left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok

Comment thread lib/cli/deprecations.js
throw new GeminiError(
util.format('Option %s is removed', option),
'Instead use ' + replacement
util.format('Option %s is removed. Instead use %s', option, replacement)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

чего сразу на template strings не перепишешь?

@sipayRT
sipayRT merged commit 740edcd into master Jan 30, 2019
@sipayRT
sipayRT deleted the sipayRT.deprecatedOptions branch January 30, 2019 10:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI deprecation error don't output replacement options

2 participants

0