This repository was archived by the owner on Sep 21, 2022. It is now read-only.
Repository navigation
feat(stats): move part of the logic to the gemini-core - #872
Merged
Merged
Conversation
DudaGod
force-pushed
the
dd.use_base_stats
branch
3 times, most recently
from
January 29, 2018 22:05
6c2dcee to
f54b812
Compare
rostik404
reviewed
Feb 1, 2018
| passed: 'passed', | ||
| failed: 'failed', | ||
| skipped: 'skipped', | ||
| retries: 'retries' |
Contributor
There was a problem hiding this comment.
Давай выше определим это, как объект с константами, а здесь напишем this._statNames = statNames.
И кстати, ключи капсом должны быть написаны - это же константы.
Member
Author
There was a problem hiding this comment.
да, это константы, но я бы капсом в этом случае ключи не писал бы. Иначе везде куда летит статистика мне нужно будет дергать название вот так:
const message = [
`Total: ${chalk.underline(stats.TOTAL)}`,
`Passed: ${chalk.green(stats.PASSED)}`,
`Failed: ${chalk.red(stats.FAILED)}`,
`Skipped: ${chalk.cyan(stats.SKIPPED)}`,
`Retries: ${chalk.yellow(stats.RETRIES)}`
];
и не забывать, что нужно обязательно их капсом указывать
DudaGod
force-pushed
the
dd.use_base_stats
branch
2 times, most recently
from
February 2, 2018 10:11
fbe605e to
c219493
Compare
rostik404
approved these changes
Feb 2, 2018
| failed: 'failed', | ||
| skipped: 'skipped', | ||
| retries: 'retries' | ||
| }; |
Contributor
There was a problem hiding this comment.
Ну здесь тоже самое, что и в hermione - я бы все таки ключи капсом назвал.
Dmitriy-kiselyov
approved these changes
Feb 2, 2018
| constructor() { | ||
| this._stats = {}; | ||
| addUpdated(test) { | ||
| return this._addStat(this._statNames.UPDATED, test); |
Contributor
There was a problem hiding this comment.
Напомню на всякий случай, либо тут updated, либо в STAT_NAMES все капсом
DudaGod
force-pushed
the
dd.use_base_stats
branch
from
February 4, 2018 21:00
c219493 to
99e7e0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.