8000 feat: Pass suiteCollection on BEGIN event to allow to modify it by j0tunn · Pull Request #728 · gemini-testing/gemini · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Sep 21, 2022. It is now read-only.

feat: Pass suiteCollection on BEGIN event to allow to modify it - #728

Merged
j0tunn merged 1 commit into
masterfrom
suite.collection.on.begin
Feb 10, 2017
Merged

j0tunn merged 1 commit into
masterfrom
suite.collection.on.begin

Conversation

@j0tunn
@j0tunn j0tunn commented Feb 9, 2017
Copy link
Copy Markdown
Contributor

No description provided.

@j0tunn
j0tunn commented Feb 9, 2017
Copy link
Copy Markdown
Contributor Author

@eGavr @sipayRT

Comment thread doc/events.md Outdated

* `STOP_BROWSER` - emitted right before browser session end. Emitted with [browser instance](../lib/browser/new-browser.js). If handler returns a promise quit will be performed only after the promise is resolved.

* `BEGIN` - runner event. Emitted on runner start with 1 argment `data`:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argUment

Comment thread test/unit/runner/index.js Outdated
return run(runner).then(() => assert.calledOnce(onBegin));
});

it('should suite collection of states when emitting "BEGIN" event', () => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should pass ...?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when emitting "BEGIN" event --> on "BEGIN" event

Comment thread doc/events.md
* `STOP_BROWSER` - emitted right before browser session end. Emitted with [browser instance](../lib/browser/new-browser.js). If handler returns a promise quit will be performed only after the promise is resolved.

* `BEGIN` - runner event. Emitted on runner start with 1 argment `data`:
* `data.suiteCollection` - suite collection which will be run
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нужно указать или все свойства через data., или все без нее

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@j0tunn
j0tunn commented Feb 9, 2017
Copy link
Copy Markdown
Contributor Author

🆙

@sipayRT
sipayRT commented Feb 9, 2017
Copy link
Copy Markdown
Member

🆗
с saucelab-ом разберусь позже

@j0tunn
j0tunn force-pushed the suite.collection.on.begin branch from 715024e to 7d04923 Compare February 10, 2017 11:39
@j0tunn
j0tunn merged commit eb554f6 into master Feb 10, 2017
@j0tunn
j0tunn deleted the suite.collection.on.begin branch February 10, 2017 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0