8000 8000 Fix "Out of the bounds" error by eGavr · Pull Request #592 · gemini-testing/gemini · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Sep 21, 2022. It is now read-only.

Fix "Out of the bounds" error - #592

Merged
eGavr merged 1 commit into
masterfrom
fix/out-of-the-bounds
Sep 13, 2016
Merged

Fix "Out of the bounds" error#592
eGavr merged 1 commit into
masterfrom
fix/out-of-the-bounds

Conversation

@eGavr
@eGavr eGavr commented Sep 9, 2016 •
edited
Loading
Copy link
Copy Markdown
Contributor

/cc @sipayRT @j0tunn

closes #543

@levonet levonet added the review label Sep 9, 2016
@coveralls
coveralls commented Sep 9, 2016 •
edited
Loading
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.09%) to 83.691% when pulling 57a632e on fix/out-of-the-bounds into bb234cf on master.

sipayRT
sipayRT reviewed Sep 9, 2016
View reviewed changes
Comment thread test/unit/image/crop-coords.js Outdated
assert.equal(cropCoords.left(), 0);
});

it('should handle cases when rectangle left coordinate is "0"', () => {
@sipayRT sipayRT Sep 9, 2016
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут в описание сбивает тот факт, что ты ноль в кавычки взял. Я думал ,что ты будешь проверять кейс, когда строку передают

@sipayRT
sipayRT commented Sep 9, 2016
Copy link
Copy Markdown
Member

ok

@eGavr
eGavr force-pushed the fix/out-of-the-bounds branch from 57a632e to 28eadf8 Compare September 9, 2016 14:01
@coveralls
coveralls commented Sep 9, 2016 •
edited
Loading
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.09%) to 83.691% when pulling 28eadf8 on fix/out-of-the-bounds into bb234cf on master.

j0tunn
j0tunn reviewed Sep 9, 2016
View reviewed changes
Comment thread lib/image/crop-coords.js Outdated
this._rect = rect;
}

left() {
@j0tunn j0tunn Sep 9, 2016
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а ты не хочешь вот это вот все геттерами сделать?

@eGavr
eGavr force-pushed the fix/out-of-the-bounds branch 2 times, most recently from 4528303 to a8861cd Compare September 9, 2016 15:57
@sipayRT sipayRT mentioned this pull request Sep 9, 2016
Open
@coveralls
coveralls commented Sep 9, 2016 •
edited
Loading
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.09%) to 83.691% when pulling a8861cd on fix/out-of-the-bounds into a513644 on master.

@coveralls
coveralls commented Sep 9, 2016
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.09%) to 83.691% when pulling a8861cd on fix/out-of-the-bounds into a513644 on master.

2 similar comments
@coveralls
coveralls commented Sep 9, 2016
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.09%) to 83.691% when pulling a8861cd on fix/out-of-the-bounds into a513644 on master.

@coveralls
coveralls commented Sep 9, 2016 •
edited
Loading
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.09%) to 83.691% when pulling a8861cd on fix/out-of-the-bounds into a513644 on master.

@eGavr
eGavr force-pushed the fix/out-of-the-bounds branch from a8861cd to 66ae781 Compare September 12, 2016 10:22
@coveralls
coveralls commented Sep 12, 2016 •
edited
Loading
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.09%) to 83.691% when pulling 66ae781 on fix/out-of-the-bounds into a513644 on master.

@eGavr eGavr mentioned this pull request Sep 12, 2016
Closed
@eGavr
eGavr force-pushed the fix/out-of-the-bounds branch from 66ae781 to f79a52e Compare September 13, 2016 09:25
@coveralls
coveralls commented Sep 13, 2016
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.09%) to 83.691% when pulling f79a52e on fix/out-of-the-bounds into a513644 on master.

1 similar comment
@coveralls
coveralls commented Sep 13, 2016 •
edited
Loading
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.09%) to 83.691% when pulling f79a52e on fix/out-of-the-bounds into a513644 on master.

@eGavr
eGavr merged commit e21a153 into master Sep 13, 2016
@eGavr
eGavr deleted the fix/out-of-the-bounds branch September 13, 2016 11:01
@levonet levonet removed the review label Sep 13, 2016
@snyk-bot snyk-bot mentioned this pull request Jul 11, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Aug 17, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Out of bounds at certain window sizes

5 participants

@eGavr @coveralls @sipayRT @j0tunn @levonet
0