8000 Fix html report working with non-urlsafe chars by SevInf · Pull Request #565 · gemini-testing/gemini · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Sep 21, 2022. It is now read-only.

Fix html report working with non-urlsafe chars - #565

Merged
SevInf merged 1 commit into
masterfrom
fix/non-urlsafe-names
Aug 26, 2016
Merged

SevInf merged 1 commit into
masterfrom
fix/non-urlsafe-names

Conversation

@SevInf
@SevInf SevInf commented Aug 25, 2016
Copy link
Copy Markdown
Contributor

#490 strikes back.

The pull request hasn't actually fixed the problem
For example:

  • the suite is named 'foo+bar'
  • the path gets escaped and the images in the report will get saved to
    images/foo%2Bbar/whatever
  • the same path will be used as URL inside report, which means that:
  • the browser will unescape the path and look for images/foo+bar/whatever,
    won't find it and show sad placeholder image instead.

The fix is:

  • move escaping back to view
  • do not escape file paths (+ is actually a valid character for a file name).

If suite contains non-urlsafe character which gets escaped, html report
breaks. For example:

- su
8000
ite is named 'foo+bar'
- path gets escaped and the images in the report will get saved to
  `images/foo%2Bbar/whatever`
- the same path will be used as url inside report, which means that:
- browser will enescape the path and look for `images/foo+bar/whatever`,
  won't find it and show sad placeholder images instead.
@SevInf
SevInf commented Aug 25, 2016
Copy link
Copy Markdown
Contributor Author

/cc @j0tunn @sipayRT

@SevInf SevInf mentioned this pull request Aug 25, 2016
@coveralls
coveralls commented Aug 25, 2016 •
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 81.498% when pulling 5a66b97 on fix/non-urlsafe-names into d08fd4d on master.

@sipayRT
sipayRT commented Aug 26, 2016
Copy link
Copy Markdown
Member

ok

@j0tunn
j0tunn commented Aug 26, 2016
Copy link
Copy Markdown
Contributor

/ok

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0