8000 Use `Kernel.ceil/1` instead of `Float.ceil/1` + `Kernel.trunc/1` by preciz · Pull Request #1 · gyson/blex · GitHub
[go: up one dir, main page]

Skip to content

Use Kernel.ceil/1 instead of Float.ceil/1 + Kernel.trunc/1 - #1

Merged
gyson merged 2 commits into
gyson:masterfrom
preciz:master
Jun 24, 2019
Merged

gyson merged 2 commits into
gyson:masterfrom
preciz:master

Conversation

@preciz
@preciz preciz commented Jun 23, 2019
Copy link
Copy Markdown
Contributor

Just a small edit to make code more terse.

@gyson
gyson commented Jun 23, 2019
Copy link
Copy Markdown
Owner

👍

Kernel.ceil/1 is 8000 only available since Elixir 1.8.0, we would need to update Elixir version requirement here as well.

`Kernel.ceil/1` is available only since 1.8.
@preciz
preciz commented Jun 23, 2019 •
Copy link
Copy Markdown
Contributor Author

I did a quick glance over Kernel.ceil/1 in the source but haven't noticed, thanks, maybe then merge later.

@gyson
gyson commented Jun 24, 2019
Copy link
Copy Markdown
Owner

Nice! I will merge this into master first. May create a new release later (probably sometime after Elixir 1.9 official available).

@gyson
gyson merged commit 1ec2aec into gyson:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0