Repository navigation
test(iio-sensor-proxy): add test for repeated ClaimAccelerometer - #12
Merged
Merged
Conversation
Owner
|
H
8000
ey, really sorry, I completely missed your PR - I meanwhile added a fix for this in #13 with an early return in chuwi-minibook/iio-sensor-proxy/src/drv-mxc6655-accel.c Lines 1557 to 1561 in f56e0e0 However, I like that you'd written a test - I think this repo really needs them. I'm more than happy to merge that if you revert the changes to |
Regression test for fstanis#13: repeated ClaimAccelerometer must still emit a reading when want_polling is already TRUE.
Contributor
Author
|
Thanks for catching this and for fixing it in #13. I reverted the changes to drv-mxc6655-accel.c, and kept the regression test. The PR is now test-only. |
DeXtroTip
force-pushed
the
fix/mxc6655-claim
branch
from
August 31, 2026 12:40
5354511 to
870817b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The driver fix from #13 is already upstream, so this PR now only adds a regression test.
Repeated
ClaimAccelerometercalls used to hang whenwant_pollingwas alreadyTRUE, because no reading was emitted. The test covers both a known orientation andcur_orient == -1, which falls back toMXC_ORIENT_RIGHT.The changes to
drv-mxc6655-accel.cwere reverted as requested.