Repository navigation
Fix missing files in meson.build - #207
Closed
CyrilBrulebois wants to merge 2 commits into
Closed
CyrilBrulebois wants to merge 2 commits into
CyrilBrulebois wants to merge 2 commits into
Conversation
Commit f7384b5 introduces a dependency on a new file (repl_inspect.py) without adding it to meson.build; this means that `make install` doesn't deploy this file, leading to trivial import issues down the line. Spotted with trivial commands like `frida -f /usr/bin/df` initially, but even `frida --help` fails: $ frida --help Traceback (most recent call last): File "/usr/bin/frida", line 6, in <module> import frida_tools.repl File "/usr/lib/python3/dist-packages/frida_tools/repl.py", line 32, in <module> from frida_tools import _repl_magic, repl_inspect ImportError: cannot import name 'repl_inspect' from 'frida_tools' (/usr/lib/python3/dist-packages/frida_tools/__init__.py) Regression first published with 17.15.0, while 17.14.1 was still fine.
While investigating the repl_inspect.py regression (addressed in the previous commit), it was spotted that other files are missing from the sources list. The consequences have not been investigated specifically but it seems prudent to ship all those files.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two commits fix a specific regression in 17.15.0 (due to the introduction of
repl_inspect.py) and a more general disparity between the contents of the Git repository and the set of files deployed by the build system.Traceback for the specific regression, starting with 17.15.0: