Set english language selected by default #2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akshatnitd PTAL. |
akshatnitd
requested changes
Sep 29, 2019
akshatnitd
reviewed
Oct 4, 2019
| @@ -327,8 +327,12 @@ class NavigationBar extends Component { | |||
|
|
|||
| handleLanguageChange = (event, index, values) => { | |||
| localStorage.setItem('languages', event.target.value); | |||
| let languages = [...event.target.value]; | |||
There was a problem hiding this comment.
Why using spread operator here?
Can' t we just do,
let languages = event.target.value;
There was a problem hiding this comment.
Ok @akshatnitd I agree , will make the changes.
Changed the handleLanguageChange such that english language is selected by default when no languages are selected by user for searching skills
akshatnitd
approved these changes
Oct 9, 2019
samagragupta
approved these changes
Oct 9, 2019
shagunarora
pushed a commit
to shagunarora/susi.ai
that referenced
this pull request
Oct 10, 2019
Changed the handleLanguageChange such that english language is selected by default when no languages are selected by user for searching skills
pulkit1joshi
pushed a commit
to pulkit1joshi/susi.ai
that referenced
this pull request
Jan 20, 2020
Changed the handleLanguageChange such that english language is selected by default when no languages are selected by user for searching skills
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2691
Changes: When all the languages are deselected it displays english as default language
Demo Link: https://pr-2921-fossasia-susi-web-chat.surge.sh