Repository navigation
Fixes the enabled/disabled filter on the private resources page. - #3988
Merged
oschwartz10612 merged 4 commits intoOct 26, 2026
Merged
Conversation
Update node
Add 1.25.3 migrations
ASPCODES
requested review from
miloschwartz and
oschwartz10612
as code owners
October 23, 2026 19:04
oschwartz10612
force-pushed
the
fix-private-resource-enabled-filter
branch
from
October 26, 2026 13:40
9413fc5 to
3c76f42
Compare
oschwartz10612
approved these changes
Oct 26, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #3935
Fixes the enabled/disabled filter on the private resources page.
The frontend already sends the
enabledquery parameter, butlistAllSiteResourcesByOrgQuerySchemadid not include it. Since the schema usesz.strictObject(), requests containingenabled=trueorenabled=falsewere rejected with a400 Bad Request. The page silently caught the error and displayed "No results found" instead of the filtered resources.Changes
enabledquery parameter to the Zod schema, transforming"true"and"false"into booleans.enabledfrom the parsed query parameters.How to test
enabled=trueandenabled=falseno longer fail with a400 Bad Request.AI Disclosure
AI was used to assist with investigating the root cause and preparing the fix. The issue was reproduced manually using the browser's Developer Tools, and the implementation was reviewed and tested by the contributor.