8000 [MNT] - Fix order of reporting values in bw limits warning by TomDonoghue · Pull Request #268 · fooof-tools/fooof · GitHub
[go: up one dir, main page]

Skip to content

[MNT] - Fix order of reporting values in bw limits warning - #268

Merged
TomDonoghue merged 1 commit into
mainfrom
bwwarn
Jun 29, 2023
Merged

TomDonoghue merged 1 commit into
mainfrom
bwwarn

Conversation

@TomDonoghue
@TomDonoghue TomDonoghue commented Jun 29, 2023 •
Copy link
Copy Markdown
Member

It turns out in our bandwidth limits warning, the variables were flipped such that it printed out wrong.

For example, with a frequency resolution of 1, and a bandwidth limit of 0.5, the current code would print:
FOOOF WARNING: Lower-bound peak width limit is < or ~= the frequency resolution: 1.00 <= 0.50

Which is unhelpfully wrong...

This PR fixes this, by switching the variables to report properly. From my checks, I think it is just the warning that prints out wrong - the actual checks of the values seem correct.

This responds to this issue as reported in #244

@voytek
voytek commented Jun 29, 2023
Copy link
Copy Markdown
Contributor

Oops! Glad it's not a code issue, just a warning issue.

@TomDonoghue TomDonoghue added the 1.1 Targetted for a fooof 1.1 release. label Jun 29, 2023
@TomDonoghue
TomDonoghue merged commit 3649bbe into main Jun 29, 2023
@TomDonoghue
TomDonoghue deleted the bwwarn branch June 29, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.1 Targetted for a fooof 1.1 release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0