8000 Add x-checker-data for ImageMagick by travier · Pull Request #126 · flathub/org.inkscape.Inkscape · GitHub
[go: up one dir, main page]
Skip to content

Add x-checker-data for ImageMagick - #126

Open
travier wants to merge 1 commit into
flathub:masterfrom
travier:imagemagick
Open

Add x-checker-data for ImageMagick#126
travier wants to merge 1 commit into
flathub:masterfrom
travier:imagemagick

Conversation

@travier
@travier travier commented Jul 8, 2022 •
edited
Loading
Copy link
Copy Markdown
Member

This also update the URL for ImageMagick sources.

@flathubbot
flathubbot commented Jul 8, 2022
Copy link
Copy Markdown
Contributor

Started test build 99802

@flathubbot
flathubbot commented Jul 8, 2022
Copy link
Copy Markdown
Contributor

Build 99802 failed

@hfiguiere
hfiguiere commented Jul 8, 2022
Copy link
Copy Markdown
Contributor

build fail because inkscape tarball changed. sigh

@hfiguiere
hfiguiere commented Jul 8, 2022
Copy link
Copy Markdown
Contributor

I think the proper URL should be https://inkscape.org/gallery/item/33449/inkscape-1.2.tar.xz

hfiguiere
hfiguiere reviewed Jul 9, 2022
View reviewed changes
Comment thread org.inkscape.Inkscape.json Resolved
@travier travier mentioned this pull request Jul 9, 2022
Closed
@travier
travier commented Jul 9, 2022
Copy link
Copy Markdown
Member Author

Needs #129 first.

@travier
travier commented Jul 10, 2022
Copy link
Copy Markdown
Member Author

bot, build

@flathubbot
flathubbot commented Jul 10, 2022
Copy link
Copy Markdown
Contributor

Queued test build for org.inkscape.Inkscape.

@travier travier changed the title Update ImageMagick and add x-checker-data Add x-checker-data for ImageMagick Jul 10, 2022
@travier
travier commented Jul 10, 2022
Copy link
Copy Markdown
Member Author

Updated this one to only add the checker config.

@flathubbot
flathubbot commented Jul 10, 2022
Copy link
Copy Markdown
Contributor

Started test build 100053

@hfiguiere
hfiguiere commented Jul 10, 2022
Copy link
Copy Markdown
Contributor

I bet the first PR the bot will open will be to update to an incompatible version.

@flathubbot
flathubbot commented Jul 10, 2022
Copy link
Copy Markdown
Contributor

Build 100053 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/97783/org.inkscape.Inkscape.flatpakref

@travier
travier commented Jul 10, 2022
Copy link
Copy Markdown
Member Author

Sure, but then we can track the dependencies that need an update and report problems upstream.

@hfiguiere
hfiguiere commented Jul 10, 2022
Copy link
Copy Markdown
Contributor

no. if the bot open PR for no reason, then it's a waste of everything. Inkscape is not a small build.

There is a way to narrow the version that are acceptable.

@travier
travier commented Jul 11, 2022
Copy link
Copy Markdown
Member Author

For future reference: https://github.com/flathub/flatpak-external-data-checker#version-constraining

hfiguiere
hfiguiere reviewed Jul 17, 2022
View reviewed changes
Comment thread org.inkscape.Inkscape.json
"x-checker-data": {
"type": "anitya",
"project-id": 1372,
"stable-only": true,
@hfiguiere hfiguiere Jul 17, 2022
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure this limit to < 7 ?

@travier travier Jul 18, 2022
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't done the work for this one yet.

@skierpage skierpage mentioned this pull request Feb 9, 2023
Closed
@Erick555
Erick555 commented Oct 5, 2024
Copy link
Copy Markdown
Contributor

The proper way is to switch to graphicsmagick: -DWITH_IMAGE_MAGICK=OFF -DWITH_GRAPHICS_MAGICK=ON. This is what people do elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@hfiguiere hfiguiere hfiguiere left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@travier @flathubbot @hfiguiere @Erick555
0