Drop --root-deps and --root-deps=rdeps emerge options #2442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option became ineffective with EAPI 7 and all trace of older EAPIs has now gone. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
This option used to install build dependencies to ROOT instead of /. This never made much sense, so the option was rendered ineffective from EAPI 7. The number of ebuilds with older EAPIs has since dwindled to nothing. A recent Portage change has made this option now install build dependencies to ROOT as well as / because this can actually be useful and doesn't cause breakage. However, it does make us more prone to cyclic dependencies when initially populating the board roots. There is no reason for us to use this option though because its main purpose is to ensure the target environment has everything it needs to rebuild itself. Given that the option didn't do anything recently, we evidently don't even require this for the developer container. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
It's from Gentoo commit ba2693dfc0f0f5535e6371c4e4d19806109537c9.
krnowak
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop
--root-deps(=rdeps)emerge options--root-depsused to install build dependencies to ROOT instead of /.--root-deps=rdepsused to drop all build dependencies entirely. These never made much sense, so both options were rendered ineffective from EAPI 7. The number of ebuilds with older EAPIs has since dwindled to nothing.Portage 3.0.66 (included in this PR) has made
--root-depsnow install build dependencies to ROOT as well as / because this can actually be useful and doesn't cause breakage.However, it does make us more prone to cyclic dependencies when initially populating the board roots. There is no reason for us to use this option though because its main purpose is to ensure the target environment has everything it needs to rebuild itself. Given that the option didn't do anything recently, we evidently don't even require this for the developer container.
How to use
This mostly concerns the build process covered by CI, but you can also check the developer container.
Testing done
The Jenkins run was successful.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.