Repository navigation
Conversation
Fodesu
force-pushed
the
feat/agent-runtime-executor-tests
branch
2 times, most recently
from
October 3, 2026 14:55
2a110c6 to
7fe95bf
Compare
Fodesu
force-pushed
the
feat/agent-runtime-executor-tests
branch
from
October 3, 2026 15:35
7fe95bf to
2b34e11
Compare
Fodesu
force-pushed
the
feat/agent-runtime-executor-tests
branch
from
October 3, 2026 15:47
2b34e11 to
06eb7cf
Compare
Fodesu
force-pushed
the
feat/agent-runtime-executor-tests
branch
from
October 3, 2026 16:05
06eb7cf to
84ebc7a
Compare
Fodesu
force-pushed
the
feat/agent-runtime-executor-tests
branch
from
October 3, 2026 16:37
84ebc7a to
1e5765e
Compare
Fodesu
force-pushed
the
feat/agent-runtime-executor-tests
branch
from
October 3, 2026 16:55
1e5765e to
cdeff57
Compare
Fodesu
force-pushed
the
feat/agent-runtime-executor-tests
branch
from
October 3, 2026 17:04
cdeff57 to
072f79c
Compare
Fodesu
force-pushed
the
feat/agent-runtime-executor-tests
branch
from
October 3, 2026 17:11
072f79c to
0c85f16
Compare
Fodesu
marked this pull request as ready for review
October 3, 2026 17:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds executor behavior tests for the execution store, worker supervision, progress, assignment replay, cancellation, and terminal outcome contracts.
Coverage
The executor tests exercise idempotent dispatch by
AssignmentKey, validation before acceptance, terminal outcome reads, attachment states, cancellation, abort, and recovery. They verify that a repeated Assignment does not create a second logical effect, that terminal state remains readable after the worker exits, and that abort closes a missing execution before a late dispatch can start it.Progress tests cover bounded provisional frames, generation resets, sequence ordering, end markers, and the distinction between progress loss and outcome loss. Supervision tests cover worker replacement, orphaned records, adoption/recovery, retryable and unknown dispatch responses, and notice delivery across the worker lifecycle. Settlement notifications are treated as wake-ups: the expected result is reread from the execution port rather than reconstructed from the notice.
The suite checks model and tool outcome variants separately, including known failures, unknown tool effects, cancellation, malformed/provider failures, and stable failure classification. It also exercises replay and retention rules so a worker restart cannot silently turn an existing external effect into a fresh attempt.
These tests target the executor contract directly and keep provider implementations out of the assertion path. They are intended to validate both local workers and later transport-backed adapters against the same lifecycle invariants.
Scope
This PR is test-only and adds no executor production code.