Blog: move "refs to custom components..." fixes #4305 #4306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jimfb |
| @@ -66,7 +68,7 @@ var Zoo = React.createClass({ | |||
| }); | |||
| ``` | |||
|
|
|||
| This change also applies to the return result of `ReactDOM.render` when passing a DOM node as the top component. References to custom component classes work exactly as before. | |||
| This change also applies to the return result of `ReactDOM.render` when passing a DOM node as the top component. | |||
There was a problem hiding this comment.
Maybe also put some text here to drive the point home?
Maybe something like:
This change also applies to the return result of
ReactDOM.renderwhen passing a DOM node (eg.span,div,img) as the top component. As with refs, this change does not affect custom components (eg.<MyFancyMenu>or<MyContextProvider>), which remain unaffected by this change.
Just to prevent the TL;DR confusion. Separate paragraph and moved up above the code block. `s/References/Refs` for consistency.
sophiebits
added a commit
that referenced
this pull request
Jul 15, 2015
Blog: move "refs to custom components..." fixes #4305
|
Sure, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to prevent the TL;DR confusion. Separate paragraph and moved up above the code block.
s/References/Refsfor consistency.