-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow wrap attribute in textarea #4237
Conversation
lgtm, cc @spicyj |
This should be added to htmlpropertyconfig, not here. @jimfb can you follow up with the details and confirm the testing is done right (look at other PRs for my comments about testing property vs attribute) |
Thanks @zpao, I hadn't gotten a chance to look. |
It seems like this new attribute should be covered by existing generic tests i.e. But since this attribute only has two legal values ( |
No, it's fine to just add it to the list of supported properties and not add a unit test, but you should test manually: Are you able to make a local build and test that this property works correctly? It's important that both the initial render and updating the property work as those exercise different codepaths. |
Yep, just built successfully and used it to both initially render and update the attribute. I can post the snippet if you want. |
It looks like this field can be either a property or an attribute (eg. https://msdn.microsoft.com/en-us/library/ms535152(v=vs.85).aspx), so should we be using |
If both work for updates, |
@jas14 Let's use |
Cool. Can you squash these to a single commit? Then we can merge. |
Thanks! |
See #4226