indicate file name requried for static file #4291
Conversation
the text doesn't say explicitly to call your file comments.json, nor to put it in the public directory.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
| @@ -374,7 +374,7 @@ var CommentBox = React.createClass({ | |||
| `getInitialState()` executes exactly once during the lifecycle of the component and sets up the initial state of the component. | |||
|
|
|||
| #### Updating state | |||
| When the component is first created, we want to GET some JSON from the server and update the state to reflect the latest data. In a real application this would be a dynamic endpoint, but for this example, we will use a static JSON file to keep things simple: | |||
| When the component is first created, we want to GET some JSON from the server and update the state to reflect the latest data. In a real application this would be a dynamic endpoint, but for this example we will keep things simple by creating a static JSON file public/comments.json containing the array of comments: | |||
|
|
|||
| ```javascript | |||
| // tutorial13.json | |||
There was a problem hiding this comment.
The tutorial is broken into steps with file names to match (eg tutorial13.js would not actually be named that on disk, just used to indicate the step of the tutorial). Honestly we could probably get rid of those comments entirely.
|
Seems reasonable to me. Also, @rwoodnz can you sign the CLA so we can merge? You know, lawyers :/ |
|
@jimfb. Cheers, yep I did the CLA. If I go to it now I get an error saying my email has already been used for it. [UPDATE have emailed the CLA address - looks like I hit agree without entering my github name] |
|
RE CLA: Well, that's annoying. I found your record in the CLA database, but there is no github account attached to the record. I'll try to figure out the CLA situation on our end and ping you when I've figured out next steps. |
|
Yep. My apologies on that one. Rushed through it and hit agree without filling in the box. After that you can't do it again. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Ok, CLA situation has been solved. @rwoodnz, if you can amend your commit to put the public/comments.json in backticks (the key just above the escape key, |
indicate file name requried for static file
|
👍 |
|
👍 |
indicate file name requried for static file (cherry picked from commit e9b3974)
the text doesn't say explicitly to call your file comments.json, nor to put it in the public directory.