8000 query params keep on getting added to the end · Issue #23 · funcool/bide · GitHub
[go: up one dir, main page]

Skip to content

query params keep on getting added to the end #23

Open

Description

@jiangts

I'm calling navigate! with the same route and params, but changing the 3rd argument, the query, causes a new set of query params to be added to the end of the URL. (instead of clearing out the previous keys).

For example, from the README if I do

(r/navigate! router :myapp/user-by-id {:id 2} {:foobar 1})
;; => "/api/users/2?foobar=1"

(r/navigate! router :myapp/user-by-id {:id 2} {:foobar 2})
;; => "/api/users/2?foobar=1?foobar=2"

Activity

  1. added a commit that references this issue on Feb 9, 2019
    2734109
  2. jiangts commented on Feb 9, 2019

    @jiangts
    Author

    I see, this is the same as #15. It'd be helpful to cut a new release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0