Repository navigation
758 add guard rails and barriers as lane boundaries to osi - #792
ClemensLinnhoff wants to merge 3 commits into
Conversation
|
I pushed a rebased (on dev) variant of this branch: https://github.com/esmini/esmini/tree/feature/pr792 For future reference, please target dev branch. And avoid merging dev branch. Either just hand over that check to us, or do a rebase on your own (instead of merge). In the end the PR is rebased on dev anyway. |
Can that branch be merged? |
|
At first glance it seems like a good solution. Hadn't found time to investigate further yet, including synching with internal stakeholders. |
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>
64c89ef to
97e6d4d
Compare
|
I rebased dev into this. I still would like to get this merged. We are mainly using esmini on this branch now, because the guard rail representation in OSI in the dev branch is simply wrong if the road has an elevation. @eknabevcc any chance we can move forward to getting this merged? |
Guard rails are currently added to OSI as stationary objects. The problem is, that this way, they cannot have a height profile, so the guard rails will not follow the elevation of the road. A better way is to implement guard rails in OSI as lane boundaries.
There are some open points, that should be discussed:
Fixes #758