[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mi_traverse() name ID override with alias tracking #461

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

leroyvn
Copy link
Member
@leroyvn leroyvn commented Nov 2, 2024

Description

This PR fixes the name ID override feature added the mi_traverse() function. Prior to this update, ID-aliased node updates could fail when the aliased object would not be declared at the top level of the scene because the scene update algorithm would not be able to reach the parent object to an ID-aliased node. This is solved by adding an alias tracking mapping to the SceneParameter object and following aliases upon scene parameter update.

Checklist

  • The code follows the relevant coding guidelines
  • The code generates no new warnings
  • The code is appropriately documented
  • The code is tested to prove its function
  • The feature branch is rebased on the current state of the main branch
  • I updated the change log if relevant
  • I give permission that the Eradiate project may redistribute my contributions under the terms of its license

@leroyvn leroyvn force-pushed the fix_traverse branch 3 times, most recently from 03b5376 to 693d214 Compare November 2, 2024 21:39
@leroyvn leroyvn marked this pull request as ready for review November 2, 2024 21:40
@leroyvn leroyvn force-pushed the fix_traverse branch 2 times, most recently from 6f6f66a to 5f9fe30 Compare November 2, 2024 22:21
@leroyvn leroyvn merged commit 9f59fef into main Nov 4, 2024
1 of 2 checks passed
@leroyvn leroyvn deleted the fix_traverse branch November 4, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant