Repository navigation
feat: release new version - #349
Conversation
Does the PR have any schema changes?Does the PR have any schema changes?Generated by schema-tools v0.8.1. Found 2 breaking changes: Functions
New types: 4Maintainer note: consult the runbook for dealing with any breaking changes. |
bd2e376 to
2a5dd61
Compare
| run: make upstream | ||
| - name: golangci-lint | ||
| uses: golangci/golangci-lint-action@v3 | ||
| uses: golangci/golangci-lint-action@v9 |
There was a problem hiding this comment.
I wouldn't expect changes to anything at .github as part of pulling in a newer terraform-provider-equinix release. Were these changes sourced from https://github.com/pulumi/pulumi-tf-provider-boilerplate or somewhere else?
There was a problem hiding this comment.
The GHA is warning about deprecated node version for this action, so I just upgraded it
| @@ -0,0 +1,53 @@ | |||
| { | |||
There was a problem hiding this comment.
Please remove this and flake.lock
There was a problem hiding this comment.
I am proposing this to the Panthers team to see if this is a good idea to introduce.
It was a huge pain trying to track down all the dependency before I could even build this project
There was a problem hiding this comment.
Pulumi provides the scaffolding for generating a Pulumi provider from a Terraform provider. The latest version of that scaffolding uses mise for dependency management. We are going to realign with the Pulumi scaffolding in the near future rather than add our own approach that further distances our Pulumi provider generation from upstream recommendations & practices, so this should be removed.
There was a problem hiding this comment.
sure, I've unstaged it
| build_python: upstream $(PULUMICTL_BIN) | ||
| rm -rf sdk/python/ | ||
| $(WORKING_DIR)/bin/$(TFGEN) python --overlays provider/overlays/python --out sdk/python/ | ||
| echo "patch_python: fix relative _utilities import in subpackage modules (codegen bug)" && \ |
There was a problem hiding this comment.
What bug does this refer to?
There was a problem hiding this comment.
Somehow, the generated code has the wrong import, even when building on master
https://github.com/equinix/pulumi-equinix/actions/runs/28552186430
There was a problem hiding this comment.
OK; when the other changes are backed out of this file, this one and the other patches for incorrect imports should stay in.
| rm -rf ./bin/ ../python.bin/ && cp -R . ../python.bin && mv ../python.bin ./bin && \ | ||
| sed -i.bak -e 's/^VERSION = .*/VERSION = "$(PYPI_VERSION)"/g' -e 's/^PLUGIN_VERSION = .*/PLUGIN_VERSION = "$(VERSION)"/g' ./bin/setup.py && \ | ||
| rm ./bin/setup.py.bak && \ | ||
| sed -i -e 's/^VERSION = .*/VERSION = "$(PYPI_VERSION)"/g' -e 's/^PLUGIN_VERSION = .*/PLUGIN_VERSION = "$(VERSION)"/g' ./bin/setup.py && \ |
There was a problem hiding this comment.
The sed -i.bak format is a cross-platform way to write this command, with the tradeoff that we have to explicitly clean up .bak files afterwards. Do not change it.
There was a problem hiding this comment.
Do we need this script to be cross platform though? The pipeline runner is handling it just fine it seems
There was a problem hiding this comment.
Yes, for now we need this script to be cross-platform.
|
This PR is included in version 0.32.0 🎉 |
No description provided.