Repository navigation
NFV-23888: introduce keyType field for public key POST and GET APIs - #21
Merged
Merged
Conversation
Contributor
|
The docs for the Create Public Key endpoint say that the key type is mandatory. Where is the default to RSA implemented? |
Contributor
Author
Hi @ctreatma, It looks like the documentation is not correct here. I have asked the content team to help fix it. From API side, this key type is optional to support backward compatibility. The default value would be RSA. In the provider code, it will also be marked as optional with default as RSA. |
ctreatma
approved these changes
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Feb release, we onboarded Arista router in our market place, but only DSA public key is accepted for this vendor. To accommodate this, a new field keyType is introduced when creating a new public key. To support backward compatibility, this new field will be marked as optional and the default value would be RSA in this case. All existing public key that we have in production is RSA key and we migrate those keys to be RSA.
More details could be found in our API documentation.
reference: https://developer.equinix.com/docs?page=/dev-docs/ne/overview