This repository was archived by the owner on Sep 4, 2026. It is now read-only.
Repository navigation
chore: upgrade to Go 1.22 - #461
Merged
Merged
Conversation
displague
added a commit
that referenced
this pull request
May 14, 2024
Using the go.mod to drive Go version choice in CI makes it easier to upgrade to newer versions of Go. Since this CLI is shipped as a binary and not meant to be used as a module, there's not much reason to do matrix testing on multiple versions of Go. This was broken out of #461 because the E2E test workflow uses a `pull_request_target` trigger. That trigger means that the workflow always uses the workflow configuration from the `main` branch, so it's impossible for the E2E workflow to pass on that PR because--if we don't merge this PR first--the workflow configuration has to be updated in order to run on a different version of Go.
ctreatma
marked this pull request as ready for review
May 14, 2024 21:00
Contributor
|
Current version of golangci-lint is 1.58.1. What's driving the choice of 1.56 over that? Also, I ran a go mod tidy and it changed the go.sum file. |
cprivitere
previously approved these changes
May 15, 2024
Contributor
Author
No idea. Probably copied from a different repo that upgraded to go 1.22 earlier. I bumped it the rest of the way now. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of this upgrade, I also upgrade golangci-lint to close #406. In order to successfully install a newer golangci-lint locally, I had to rip out the
hack/toolsworkflow and run the linter in a container instead. Per the golangci-lint docs, installing binaries or using a container is preferred for local installation, andgo install(which is what thehack/toolsworkflow used) is not guaranteed to work: https://golangci-lint.run/welcome/install/#install-from-source