8000 fix: handle optional flags correctly in VRF route update by ctreatma · Pull Request #441 · equinix/metal-cli · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Sep 4, 2026. It is now read-only.

fix: handle optional flags correctly in VRF route update - #441

Merged
cprivitere merged 4 commits into
mainfrom
fix-route-update
Jan 31, 2024
Merged

fix: handle optional flags correctly in VRF route update#441
cprivitere merged 4 commits into
mainfrom
fix-route-update

Conversation

@ctreatma
@ctreatma ctreatma commented Jan 30, 2024 •
edited by displague
Loading
Copy link
Copy Markdown
Contributor

The test for the VRF route update subcommand was explicitly skipped. I added a helper function to wait for the VRF route to be ready before testing the update subcommand, but when the test was enabled it failed because the subcommand was not capable of updating tags without updating all other VRF route properties.

In addition to enabling the test for the VRF route update subcommand, this updates the subcommand itself so that it only updates a VRF route property if the user set the corresponding CLI flag.

Part of #414

@ctreatma ctreatma mentioned this pull request Jan 30, 2024
Merged
@ctreatma
ctreatma requested a deployment to internal January 30, 2024 19:38 — with GitHub Actions Abandoned
@cprivitere
cprivitere requested a deployment to internal January 30, 2024 20:25 — with GitHub Actions Abandoned
@cprivitere
cprivitere commented Jan 30, 2024
Copy link
Copy Markdown
Contributor

Looks like the vrf-route-update-test is panicking after 30 seconds.

@cprivitere
cprivitere requested a deployment to internal January 30, 2024 21:58 — with GitHub Actions Abandoned
@displague
displague commented Jan 30, 2024
Copy link
Copy Markdown
Member

There have been conversations about adding a --wait argument for create subcommands. The code used in testing could be surfaced as a feature in the future.

@ctreatma
ctreatma commented Jan 30, 2024
Copy link
Copy Markdown
Contributor Author

Looks like the vrf-route-update-test is panicking after 30 seconds.

I see a panic happening in a different test due to the test timeout being reached (~1000 seconds) and the VRF route update test failing because the route isn't ready in time. I triggered a re-run of the tests to see if the route update times out again. We may need to extend the test timeout (terraform uses 180m)

ctreatma
ctreatma commented Jan 30, 2024
View reviewed changes
Comment thread test/helper/helper.go Resolved
displague
displague reviewed Jan 30, 2024
View reviewed changes
Comment thread test/helper/helper.go Resolved
@ctreatma
ctreatma requested a deployment to internal January 31, 2024 17:37 — with GitHub Actions Abandoned
@ctreatma
ctreatma requested a deployment to internal January 31, 2024 22:11 — with GitHub Actions Abandoned
cprivitere
cprivitere approved these changes Jan 31, 2024
View reviewed changes
@cprivitere cprivitere left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are flakey but passing in general. The ones added in this PR pass and that's what matters.

@cprivitere
cprivitere merged commit 10d7143 into main Jan 31, 2024
@cprivitere
cprivitere deleted the fix-route-update branch January 31, 2024 22:52

This branch had an error being deployed

1 abandoned deployment
internal — 49b48269 Deployed Jan 31, 2024 by ctreatma
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@displague displague displague left review comments
@cprivitere cprivitere cprivitere approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ctreatma @cprivitere @displague
0