8000 use and honor OTEL_EXPORTER_OTLP_PROTOCOL · Issue #142 · equinix-labs/otel-cli · GitHub
[go: up one dir, main page]

Skip to content

use and honor OTEL_EXPORTER_OTLP_PROTOCOL #142

Closed

Description

@tobert

In the review of #138 @cyrille-leclerc notes that when merged, otel-cli will be oblivious to OTEL_EXPORTER_OTLP_PROTOCOL, so it's possible for a user to set that envvar in conflict with otel-cli's assumptions, and create a broken situation.

To resolve this, otel-cli will need to support the OTEL_EXPORTER_OTLP_PROTOCOL variable and variants itself, and prioritize them over the rules documented in the README. This will allow for grpc to use http endpoints cleanly according to the spec, while allowing otel-cli to deviate a bit to provide a clearer UX to command-line users.

I'm going to merge #138 and will take care of this before releasing v0.1.0 (next release) so the behavior is set and consistent going forward.

Activity

  1. added a commit that references this issue on Jan 26, 2023
  2. cyrille-leclerc commented on Jan 27, 2023

    @cyrille-leclerc

    Thank you very much @tobert. Some use cases I have in mind to NOT use grpc for OTLP:

    • The endpoint of some observability platforms prefer 'http' to 'grpc' (e.g. Grafana Cloud as documented here)
    • Some organizations use outbound proxies for their internet traffic and sometimes 'grpc' is not yet supported, only 'http' being supported
  3. self-assigned this
    on Jan 27, 2023
  4. added
    documentationImprovements or additions to documentation
    enhancementNew feature or request
    patchpatch semver
    on Jan 27, 2023
  5. added a commit that references this issue on Jan 27, 2023
  6. tobert commented on Jan 30, 2023

    @tobert
    ContributorAuthor

    It looks like opentelemetry-go does not support JSON export over OTLP. I'm going to remove mentions and hints at support for it so we just have http/protobuf and grpc. If folks really want/need http/json we'll have to implement it manually in otel-cli.

  7. cyrille-leclerc commented on Jan 30, 2023

    @cyrille-leclerc

    Thanks @tobert !
    From what I understood, OTLP on http/json is primarily used for RUM use cases, for the opentelemetry-js SDK (see exporter-trace-otlp-http and opentelemetry-exporter-metrics-otlp-http).

    http/protobuf is more for server side usage, when GRPC is not supported.

  8. added a commit that references this issue on Jan 31, 2023
  9. tobert commented on Feb 2, 2023

    @tobert
    ContributorAuthor

    I believe this is solved in the v0.1.0 release :) Please reopen if I missed something important.

    https://github.com/equinix-labs/otel-cli/releases/tag/v0.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

documentationImprovements or additions to documentationenhancementNew feature or requestpatchpatch semver

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    0