-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating transmissibility template #144
Conversation
7e68be9
to
f176074
Compare
… corresponding rmd chunk
… provided mean/sd and when these are obtained from {epiparameter}
…es so it's understandable by external readers
…stimates for days defined by "r_estim_window"
…oup data according to different variables
…ch dates are used in the analysis
…h dates are used in the analysis
…/tables in i2extras chunk
…rinted in the report
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I browsed through the changes and it looks all good to me. Only comment is that I wouldn't put include = FALSE
on any chunks.
In my opinion, we should display or hide all chunks, not just some of them.
I confirm the reports render without issues on my local computer.
inst/rmarkdown/templates/transmissibility/skeleton/skeleton.Rmd
Outdated
Show resolved
Hide resolved
inst/rmarkdown/templates/transmissibility/skeleton/skeleton.Rmd
Outdated
Show resolved
Hide resolved
inst/rmarkdown/templates/transmissibility/skeleton/skeleton.Rmd
Outdated
Show resolved
Hide resolved
Co-authored-by: Hugo Gruson <10783929+Bisaloo@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
===========================================
- Coverage 73.07% 30.00% -43.08%
===========================================
Files 4 3 -1
Lines 26 10 -16
===========================================
- Hits 19 3 -16
Misses 7 7 ☔ View full report in Codecov by Sentry. |
inst/rmarkdown/templates/transmissibility/skeleton/rmdchunks/EpiNow2.Rmd
Outdated
Show resolved
Hide resolved
…piNow2.Rmd Co-authored-by: Hugo Gruson <10783929+Bisaloo@users.noreply.github.com>
Changes in this branch:
episoap
templates #120EpiNow2::dist_spec()
withEpiNow2::pmf()
when appropriate #131regional_epinow
#118