Repository navigation
feat: add opt-in charset/encoding negotiation to ContentNegotiationMiddleware - #116
Merged
Merged
Conversation
…ddleware ContentNegotiator defines bestAllowedCharset and bestAllowedEncoding but the middleware never called them. Add allowedCharsets and allowedEncodings configuration fields (default null = skip). When configured, the middleware negotiates Accept-Charset / Accept-Encoding and stores results on the request via ContentNegotiable. Add charset/encoding accessors to ContentNegotiable interface. Closes #112 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowedCharsetsandallowedEncodingsconfiguration toContentNegotiationMiddleware(defaultnull= no negotiation, backward compatible)Accept-Charset/Accept-Encodingheaders and store results on the requestgetCharset()/setCharset()/getEncoding()/setEncoding()toContentNegotiableinterfaceContentNegotiatormethods are now reachable from the middleware, eliminating dead codeCloses #112
Usage
Test plan
charsetAndEncodingNotNegotiatedByDefault— null by default, backward compatiblecharsetNegotiatedWhenConfigured—Accept-Charset: utf-8→getCharset()="utf-8"encodingNegotiatedWhenConfigured—Accept-Encoding: gzip→getEncoding()="gzip"charsetAndEncodingBothConfigured— both set together🤖 Generated with Claude Code