[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to open sidebars #100

Closed
wants to merge 1 commit into from
Closed

Conversation

Lo10Th
Copy link
@Lo10Th Lo10Th commented Oct 26, 2023

I was not able to open the left and right sidebars. I think I am the first to have this problem, but I have partially solved it myself. Please correct me if I am wrong.

If I am correct, the toggle-sideleft and toggle-sideright scripts are responsible for opening the windows after the mouse click. Somehow, by simply moving the command, I managed to get the bar to open.

The other problem:
Somehow, the sidebar only opens when I run the new script manually. By simply clicking, nothing happens. Even if I restart eww or reboot my system, the sidebars are still only opened by the customized script. Maybe I'm just stupid or something and don't know how to handle an update of the scripts. I am just a beginner

If you still don't understand what I've described here, I've created a video that explains the whole thing. For the right sidebar it's the same, I took the left sidebar as an example.

untitled.mp4

I also wanted to thank you for making this all open source and taking so much time to do it.

@Lo10Th Lo10Th marked this pull request as ready for review October 26, 2023 18:57
@Lo10Th Lo10Th marked this pull request as draft October 26, 2023 19:00
@end-4
Copy link
Owner
end-4 commented Oct 27, 2023

can confirm that it does happen
the open command is put before the other var setting ones so that there's animation, so changing the order makes it not have anims

@Lo10Th
Copy link
Author
Lo10Th commented Oct 28, 2023

yes ok that makes sense, but if I didn't care about the animations, what do I have to do so that the script is also executed when I press top left?
Anyway, I should close the pr then or?

@end-4
Copy link
Owner
end-4 commented Oct 28, 2023

Press to open

  • Modify the first :onclick property you see in modules/osd_volume.yuck, modules/osd_bright.yuck, modules/dynamicleft.yuck, and modules/dynamicright.yuck

This pr

  • Yeah if you understand what i said ↑ then close it
  • Just use that issue (# 99) if you wanna report further information about this window opening problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants