issue-5714 - incorrect _cache_key generation fixed #5715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sekar Saravanan <sekar.saravanan@hotstar.com>
Merged
|
I'm going to close this in favor of #5716 – @sekar-saravanan, thanks! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
_cache_key is getting generated incorrectly for mappings in ir.json, when using header with regex. Always _cache_key should be in the format of {kind}-{version}-{name}-{namespace}. But header name is getting updated in the place of mapping name
Related Issues
#5714
Testing
manual tests
Checklist
Does my change need to be backported to a previous release?
I made sure to update
CHANGELOG.md.This is unlikely to impact how Ambassador performs at scale.
My change is adequately tested.
I updated
DEVELOPING.mdwith any any special dev tricks I had to use to work on this code efficiently.The changes in this PR have been reviewed for security concerns and adherence to security best practices.