issue-5714 - incorrect _cache_key generation fixed

Signed-off-by: Sekar Saravanan <sekar.saravanan@hotstar.com>
emissary-ingress · Jul 5, 2024 · e8ca650 · e8ca650
1 parent 5f7ac30
commit e8ca650
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -135,6 +135,12 @@ it will be removed; but as it won't be user-visible this isn't considered a brea
   starting. This will help address  some of the intermittent issues seen during install and
   upgrades.
 
+- Bugfix: _cache_key is getting generated incorrectly for mappings in ir.json, when using header
+  with regex in mapping. Always, It should be in the format of {kind}-{version}-{name}-{namespace}. 
+  But header name is getting updated in the place of mapping name, if we created mapping with regex 
+  header.
+
+
 ## [3.8.0] August 29, 2023
 [3.8.0]: https://github.com/emissary-ingress/emissary/compare/v3.7.2...v3.8.0
 

diff --git a/python/ambassador/ir/irhttpmapping.py b/python/ambassador/ir/irhttpmapping.py
@@ -241,8 +241,8 @@ def __init__(
         if "regex_headers" in kwargs:
             # DON'T do anything special with a regex :authority match: we can't
             # do host-based filtering within the IR for it anyway.
-            for name, value in kwargs.get("regex_headers", {}).items():
-                hdrs.append(KeyValueDecorator(name, value, regex=True))
+            for hdr_name, hdr_value in kwargs.get("regex_headers", {}).items():
+                hdrs.append(KeyValueDecorator(hdr_name, hdr_value, regex=True))
 
         if "host" in kwargs:
             # It's deliberate that we'll allow kwargs['host'] to silently override an exact :authority