Improve failure message for case where a given label doesn't match #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It distinguishes three cases about the id specified by the "for" attribute: * does not exist * exists once (but must be failing because of a type mismatch) * exists multiple times [Fixes elixir-wallaby#634]
811ca2d
to
2e746e2
Compare
Codecov Report
@@ Coverage Diff @@
## main #640 +/- ##
===========================================
- Coverage 92.62% 41.50% -51.12%
===========================================
Files 24 24
Lines 922 930 +8
===========================================
- Hits 854 386 -468
- Misses 68 544 +476
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It distinguishes three cases about the id specified by the "for" attribute:
[Fixes #619]