Repository navigation
fix: accept any Content-Disposition type when reading the filename - #50
Merged
Merged
Conversation
HTTPDownloaderBase.extension() asserted that the Content-Disposition header was 'attachment'. Servers such as ECPDS (diss.ecmwf.int) send 'inline; filename=...', which RFC 6266 allows, so downloads failed with an AssertionError. The filename is now used whatever the disposition type, as title() already does. Add offline tests for inline, attachment and custom disposition types, and a local HTTP server test. Refs ecmwf/earthkit-data#1205
iainrussell
approved these changes
Oct 29, 2026
Member
There was a problem hiding this comment.
I've had a look and am happy with this fix
EddyCMWF
approved these changes
Nov 9, 2026
Collaborator
There was a problem hiding this comment.
This assertion has been there since the start. As far as I can tell, if it is a problem it will just manifest in a different exception type for the downstream user elsewhere in the multiurl codebase.
I have checked cads-adaptors and ecmwf-datastores-client, and I believe they are not effected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #49
HTTPDownloaderBase.extension() asserted that the Content-Disposition header was 'attachment'. Servers such as ECPDS (diss.ecmwf.int) send 'inline; filename=...', which RFC 6266 allows, so downloads failed with an AssertionError. The filename is now used whatever the disposition type, as title() already does.
Add offline tests for inline, attachment and custom disposition types, and a local HTTP server test.
Refs ecmwf/earthkit-data#1205
Contributor Declaration
By opening this pull request, I affirm the following: