test (jkube-kit) : Add ImageName upstream compatibility tests #2519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #2519 (2024-01-11T17:54:22Z) ⚙️ JKube E2E Tests (7492526819)
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2519 +/- ##
============================================
+ Coverage 59.36% 69.11% +9.75%
- Complexity 4586 4847 +261
============================================
Files 500 473 -27
Lines 21211 19141 -2070
Branches 2830 2485 -345
============================================
+ Hits 12591 13230 +639
+ Misses 7370 4711 -2659
+ Partials 1250 1200 -50 ☔ View full report in Codecov by Sentry. |
manusa
requested changes
Jan 10, 2024
0bd6a00
to
19c97fc
Compare
manusa
requested changes
Jan 10, 2024
Comment on lines
74
to
81
| //"[2001:db8::1]/repo", // Ipv6 | ||
| //"[2001:db8:1:2:3:4:5:6]/repo:tag", // Ipv6 | ||
| //"[2001:db8::1]:5000/repo", // Ipv6 | ||
| //"[2001:db8::1]:5000/repo:tag", // Ipv6 | ||
| //"[2001:db8::1]:5000/repo@sha256:ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff", // Ipv6 | ||
| //"[2001:db8::1]:5000/repo:tag@sha256:ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff", // Ipv6 | ||
| //"[2001:db8::]:5000/repo", // Ipv6 | ||
| //"[::1]:5000/repo", // Ipv6 |
There was a problem hiding this comment.
Does // IPv6 imply what's stated later Invalid Ipv6 addresses - these are failing because we only support IPv4 at the moment
In my previous comment I was requesting the reason why the test is disabled. IPv5 is not a reason. A reason might be that IPv6 is not supported on upstream Docker as a valid image name, or whatever the justifiable reason is why we're no supporting IPv6.
There was a problem hiding this comment.
okay, let me add more detail to this comment. These are valid Ipv6 addresses that ImageName fails to parse. I checked docker source and I saw that they now do have support for Ipv6 addresses but it's not available on the latest version v24.0.8. Maybe it would be available in upcoming releases.
19c97fc
to
4fc13b9
Compare
Add tests for ImageName for ORAS reference and Docker Distribution reference. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
4fc13b9
to
ab4f0bb
Compare
|
manusa
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tests for ImageName for ORAS reference and Docker Distribution reference. These tests mainly test the
ParseReferencefunctionality in upstream equivalents.This also includes some cases that might not be available in the latest versions of Docker. For example, support for IPv6 registries was added in distribution/distribution#3489 but I didn't find it in Docker v24.0.7
The tests that have been commented out represent missing support in ImageName behavior with regards to validating image names.
Type of change
test, version modification, documentation, etc.)
Checklist