Lints and undef fixes

example42 · Oct 19, 2023 · 4ff4020 · 4ff4020
1 parent 5d171cb
commit 4ff4020
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # CHANGELOG
 
+## 3.10.1
+
+-   Changed CI containers used
+-   Added unit tests for Puppet 6, 7 and 8
+-   Lints and fix on undefined vars
+
 ## 3.10.0
 
 -   Added support for $MAJVERSION variable in tinydata

diff --git a/manifests/install.pp b/manifests/install.pp
@@ -239,11 +239,11 @@
   $extracted_file = getvar('tp_settings.release.extracted_file')
 
   $local_settings = delete_undef_values({
-      install_method => $real_install_method,
-      repo           => $repo,
-      upstream_repo  => $upstream_repo,
+      install_method => getvar('real_install_method'),
+      repo           => getvar('repo'),
+      upstream_repo  => getvar('upstream_repo'),
       git_source     => $real_install_method ? {
-        'source' => $source,
+        'source' => getvar('source'),
         default  => undef,
       },
       destination    => $real_install_method ? {
@@ -255,11 +255,11 @@
           name => tp::title_replace(getvar('settings.packages.main.name'),$app),
       }),
       release => delete_undef_values({
-          base_url       => pick_default(getvar('real_base_url')),
-          file_name      => $real_filename,
-          url            => $real_url,
-          extracted_dir  => $extracted_dir,
-          extracted_file => $extracted_file,
+          base_url       => getvar('real_base_url'),
+          file_name      => getvar('real_filename'),
+          url            => getvar('real_url'),
+          extracted_dir  => getvar('extracted_dir'),
+          extracted_file => getvar('extracted_file'),
           setup => delete_undef_values({
               enable => getvar('tp_settings.release.setup.enable'),
               links  => getvar('tp_settings.release.setup.links'),

diff --git a/metadata.json b/metadata.json
@@ -1,6 +1,6 @@
 {
   "name": "example42-tp",
-  "version": "3.10.0",
+  "version": "3.10.1",
   "author": "example42",
   "summary": "Tiny Puppet",
   "license": "Apache-2.0",