This repository has been archived by the owner on Oct 6, 2023. It is now read-only.
Clean up the code. #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yanggang <gang.yang@daocloud.io>
everpeace
approved these changes
May 10, 2023
There was a problem hiding this comment.
@yanggangtony Thank you very much for cleaning up my old code!
| @@ -112,7 +112,6 @@ func NewPlugin(configuration runtime.Object, fh framework.Handle) (framework.Plu | |||
| ) | |||
|
|
|||
| scheduleInformerFactory.Start(ctx.Done()) | |||
| scheduleInformerFactory.WaitForCacheSync(ctx.Done()) | |||
| @@ -249,7 +248,6 @@ func (pl *KubeThrottler) Unreserve( | |||
| if err != nil { | |||
| utilruntime.HandleError(errors.Wrapf(err, "Failed to unreserve pod %s/%s in ThrottleController", pod.Namespace, pod.Name)) | |||
| } | |||
| pod.GetName() | |||
Merged
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind cleanup
Hey @everpeace .
I unintentionally search this repo from the k/k main repos.
I recently are learn and research the k8s code .
Just do some clean code for kube-throttler.
If this pr is make something mess , please feel free to told me..
Thanks.