[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log catch errors #211

Merged
merged 11 commits into from
Jan 12, 2024
Merged

Log catch errors #211

merged 11 commits into from
Jan 12, 2024

Conversation

SergiuBota1
Copy link
Member

Copy link
codecov bot commented Jan 9, 2024

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (2eb6e2d) 65.22% compared to head (79771db) 63.97%.

Files Patch % Lines
src/Admin/src/Controller/AdminController.php 0.00% 60 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                4.0     #211      +/-   ##
============================================
- Coverage     65.22%   63.97%   -1.26%     
- Complexity      363      368       +5     
============================================
  Files            49       49              
  Lines          1734     1782      +48     
============================================
+ Hits           1131     1140       +9     
- Misses          603      642      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarioRadu
Copy link
Member

Please write unit test cases that cover the new lines.

src/Admin/src/Controller/AdminController.php Outdated Show resolved Hide resolved
src/App/assets/js/components/_admin.js Outdated Show resolved Hide resolved
src/App/assets/js/components/_admin.js Outdated Show resolved Hide resolved
src/App/assets/js/components/_admin.js Outdated Show resolved Hide resolved
@arhimede arhimede merged commit 5f18331 into 4.0 Jan 12, 2024
10 of 12 checks passed
@alexmerlin alexmerlin deleted the issue-209 branch February 26, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants