[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change theme to adminator #203

Merged
merged 7 commits into from
Dec 12, 2023
Merged

change theme to adminator #203

merged 7 commits into from
Dec 12, 2023

Conversation

arhimede
Copy link
Member

No description provided.

Copy link
gitguardian bot commented Dec 12, 2023

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
8876550 Google API Key b724c18 src/App/assets/js/components/_googleMaps.js View secret
8876550 Google API Key bd8d687 src/App/assets/js/components/_googleMaps.js View secret
8876550 Google API Key 17eee28 public/js/app.js View secret
8876550 Google API Key 7a8566e public/js/app.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link
codecov bot commented Dec 12, 2023

Codecov Report

Attention: 160 lines in your changes are missing coverage. Please review.

Comparison is base (898439a) 71.05% compared to head (7a8566e) 65.22%.

Files Patch % Lines
src/Setting/src/Controller/SettingController.php 0.00% 89 Missing ⚠️
src/Setting/src/Entity/Setting.php 0.00% 26 Missing ⚠️
...g/src/InputFilter/Input/SettingIdentifierInput.php 0.00% 14 Missing ⚠️
.../src/InputFilter/Input/SettingValueInputFilter.php 0.00% 10 Missing ⚠️
src/Setting/src/Service/SettingService.php 0.00% 10 Missing ⚠️
src/App/src/Controller/PageController.php 0.00% 4 Missing ⚠️
src/Setting/src/Repository/SettingRepository.php 0.00% 4 Missing ⚠️
src/Setting/src/InputFilter/SettingInputFilter.php 0.00% 2 Missing ⚠️
src/Admin/src/Controller/AdminController.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                4.0     #203      +/-   ##
============================================
- Coverage     71.05%   65.22%   -5.84%     
- Complexity      328      363      +35     
============================================
  Files            39       49      +10     
  Lines          1534     1734     +200     
============================================
+ Hits           1090     1131      +41     
- Misses          444      603     +159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arhimede arhimede merged commit 2d9a872 into 4.0 Dec 12, 2023
11 of 14 checks passed
@alexmerlin alexmerlin deleted the issue-195-2 branch February 26, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants