[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not use HasLifecycleCallbacks on traits #266

Closed
alexmerlin opened this issue Jul 17, 2024 · 0 comments · Fixed by #269
Closed

Should not use HasLifecycleCallbacks on traits #266

alexmerlin opened this issue Jul 17, 2024 · 0 comments · Fixed by #269
Assignees
Labels

Comments

@alexmerlin
Copy link
Member

Nothing that would break the code - it's just a small issue I've identified during reviewing #265


Issue:

As explained here:

Class-level traits must be on the class, not on the trait. The trait does not exist at runtime, only its properties and methods.

Affected files:

https://github.com/dotkernel/admin/blob/5.0/src/App/src/Entity/TimestampsTrait.php#L10

Affected versions: 5.x

Solution:

Remove attribute #[ORM\HasLifecycleCallbacks] from src/App/src/Entity/TimestampsTrait.php becuase it does nothing.

@arhimede arhimede added the 5.0 x label Jul 25, 2024
alexmerlin added a commit that referenced this issue Jul 29, 2024
Signed-off-by: Alex Karajos <alex.merlin.1985@gmail.com>
@alexmerlin alexmerlin self-assigned this Jul 29, 2024
arhimede added a commit that referenced this issue Jul 30, 2024
Issue #266: Removed `HasLifecycleCallbacks` from `TimestampsTrait.php`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants