Repository navigation
Fix repeated callee handling in IsTrivial - #1831
Closed
dajiaohuang wants to merge 1 commit into
Closed
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
Author
|
Closing this duplicate after comparing the current patches. The same defect and fix are already covered by #1795. Keeping the existing contribution avoids competing review threads; the contributor branches remain preserved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsTrivial used its seen map as both a recursion detector and a permanent visited set. A trivial callee reached through one branch remained in the set, so another branch calling that same callee was misclassified as recursive. Keep seen scoped to the active call path by removing each function when its recursive check returns. Static call-graph review and git diff --check only; tests were not run per audit instructions.