Repository navigation
analysis/dfa/sparse: schedule mapped value users - #1823
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward updates abstract state for each Mapping.Value returned by the transfer function. That mapped value may differ from the instruction currently being processed, as supported by the Propagate(dst, src, ...) helper. When its state changes, the worklist must therefore reschedule users of the mapped value.
The previous code rescheduled instr.Referrers() instead. This can leave users of the changed destination unvisited; processing an instruction whose Referrers returns nil can also dereference a nil list. The patch uses d.Value.Referrers() and skips an absent list.
Validation: inspected the production worklist loop, Mapping/Transfer contract and Propagate helper; git diff --check was previously run. No tests or build were run for this source-only submission. No complete analyzer/runtime validation is claimed.