Repository navigation
Return cache directory configuration errors - #1818
Closed
dajiaohuang wants to merge 1 commit into
Closed
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
Author
|
Closing this duplicate after comparing the current patches. The same defect and fix are already covered by #1798. Keeping the existing contribution avoids competing review threads; the contributor branches remain preserved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When STATICCHECK_CACHE is relative, DefaultDir records an error and returns an empty path. initDefaultCache currently ignores that error and calls log.Fatalf after MkdirAll fails, even though Default exposes an error-returning contract and lintcmd propagates it to the CLI. Return from initialization when the cached directory error is set so Default returns the intended error.