Repository navigation
Initialize recover dominator root independently - #1814
Closed
dajiaohuang wants to merge 1 commit into
Closed
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
Author
|
Withdrawing this change after checking the complete supported IR path. Recover blocks are documented to contain only loads of named results followed by Return, and createRecoverBlock constructs exactly that terminal block. sanityCheckDomTree explicitly skips Recover in the relation comparison. Its reference bit therefore does not propagate to successors or change validation for supported IR; this patch corrects an internal initialization inconsistency without an established actual failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dominator sanity checker initialized the synthetic recover root's set with the entry block bit. Initialize each root with its own bit so the reference relation matches the documented rule that roots are dominated only by themselves.