Repository navigation
Fix composite literal AST equality - #1800
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QF1002 compares each case operand using astutil.Equal. The composite-literal loop compares the second literal elements to themselves, so distinct array literals are treated as equal and the suggested tagged switch changes behavior.
For example, conditions
[1]int{1} == aand[1]int{2} == bare incorrectly combined into a switch on the first literal. With a=[1]int{0} and b=[1]int{2}, the original second branch runs, but the suggested rewrite misses it. Compare corresponding elements across the two literals.Validation: the actual pre-fix QF1002 analyzer emits that suggestion; applying it changes the example result from 2 to 0. PR head 46d738d emits no suggestion for those distinct operands. Earlier focused AST equality regressions passed. This does not claim full-suite or current upstream CI acceptance.