8000 Return base64 close errors from cache helper writes by dajiaohuang · Pull Request #1799 · dominikh/go-tools · GitHub
[go: up one dir, main page]
Skip to content

Return base64 close errors from cache helper writes #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dajiaohuang wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Return base64 close errors from cache helper writes #1799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc2e860
go/ir: avoid canonicalizing function signatures
dajiaohuang Oct 1, 2026
b423ddc
return cache helper base64 close errors
dajiaohuang Oct 1, 2026
51e576f
Keep cache flush fix independent of generic IR change
dajiaohuang Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lintcmd/cache/prog.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ func (c *ProgCache) writeToChild(req *cacheprog.Request, resc chan<- *cacheprog.
return err
}
if err := e.Close(); err != nil {
return nil
return err
}
if wrote != req.BodySize {
return fmt.Errorf("short write writing body to GOCACHEPROG for action %x, output %x: wrote %v; expected %v",
Expand Down
54 changes: 54 additions & 0 deletions lintcmd/cache/prog_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
package cache

import (
"bufio"
"bytes"
"encoding/json"
"errors"
"strings"
"testing"

"honnef.co/go/tools/lintcmd/cache/cacheprog"
)

var errTestWriter = errors.New("test writer failed")

type failingWriter struct{}

func (failingWriter) Write([]byte) (int, error) { return 0, errTestWriter }

func TestWriteToChildReturnsBase64CloseError(t *testing.T) {
const groups = 1000
bodySize := groups*3 + 1 // The base64 encoder buffers a final padded group.
body := strings.Repeat("x", bodySize)
req := &cacheprog.Request{
ID: 1,
Command: cacheprog.CmdPut,
ActionID: []byte{1},
OutputID: []byte{2},
BodySize: int64(bodySize),
}
var header bytes.Buffer
if err := json.NewEncoder(&header).Encode(req); err != nil {
t.Fatal(err)
}
// Leave three bytes available after the request header and the unpadded
// base64 body, so the final padded group makes the buffer flush and fail
// from Encoder.Close.
bufferSize := header.Len() + 2 + groups*4 + 3
pc := &ProgCache{
inFlight: map[int64]chan<- *cacheprog.Response{},
bw: bufio.NewWriterSize(failingWriter{}, bufferSize),
}
pc.jenc = json.NewEncoder(pc.bw)
got := pc.writeToChild(&cacheprog.Request{
Command: cacheprog.CmdPut,
ActionID: []byte{1},
OutputID: []byte{2},
Body: strings.NewReader(body),
BodySize: int64(bodySize),
}, make(chan *cacheprog.Response, 1))
if !errors.Is(got, errTestWriter) {
t.Fatalf("writeToChild error = %v, want %v", got, errTestWriter)
}
}
0