8000 Propagate go.mod restoration errors by dajiaohuang · Pull Request #1779 · dominikh/go-tools · GitHub
[go: up one dir, main page]
Skip to content

Propagate go.mod restoration errors #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dajiaohuang wants to merge 3 commits into from
Closed

Propagate go.mod restoration errors #1779

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc2e860
go/ir: avoid canonicalizing function signatures
dajiaohuang Oct 1, 2026
51550b3
Propagate go.mod restoration errors
dajiaohuang Oct 1, 2026
4aacb68
Keep fix independent of generic IR change
dajiaohuang Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/xtools-internal/packagestest/expect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ func goModMarkers(e *Exported, gomod string) ([]*expect.Note, error) {
gomod = strings.TrimSuffix(gomod, ".temp")
// If we are in Modules mode, copy the original contents file back into go.mod
if err := os.WriteFile(gomod, content, 0644); err != nil {
return nil, nil
return nil, err
}
return expect.Parse(e.ExpectFileSet, gomod, content)
}
Expand Down
0