Repository navigation
Fix SA4026 fixes for math imports - #1768
Open
dajiaohuang wants to merge 2 commits into
Open
dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SA4026 offers a math.Copysign fix only when a usable math package import is visible at the diagnostic position, preserving that file's actual import alias. Imports from another file and locally shadowed aliases do not produce an unsafe fix; the diagnostic is retained.
The review follow-up also removes a nil report option that would panic when no usable math import exists. Regression/golden fixtures cover an aliased import, a second file without the import, and a locally shadowed alias.
Validation: go test ./staticcheck/sa4026 passed (two tests); gofmt and git diff --check passed.