Repository navigation
staticcheck: preserve import aliases in fixes - #1761
Open
dajiaohuang wants to merge 5 commits into
Open
dajiaohuang wants to merge 5 commits into
dajiaohuang wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SA1004, SA1008, SA1012, SA1016 and SA6005 preserve existing package aliases in suggested fixes. SA1016 omits its syscall replacement when the current file has no usable named syscall import.
The review follow-up avoids selector assertion panics for dot-imported Sleep/ToLower/ToUpper calls, retaining diagnostics without unsafe fixes. HTTP/context/syscall qualifier lookup verifies the imported package is still visible at the diagnostic position, so local shadowing cannot produce an invalid replacement. SA1016 can still offer its independent argument-removal fix.
Regression/golden fixtures cover aliased imports, missing imports, dot imports and local shadowing. Validation: go test ./staticcheck/sa1004 ./staticcheck/sa1008 ./staticcheck/sa1012 ./staticcheck/sa1016 ./staticcheck/sa6005 passed (11 tests); gofmt and git diff --check passed.