Repository navigation
simple: preserve time aliases in fixes - #1760
Open
dajiaohuang wants to merge 2 commits into
Open
dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S1012, S1024 and S1037 preserve the time package qualifier from the matched call when generating Since, Until and Sleep fixes. Aliased-import regression fixtures cover each check.
The review follow-up handles dot-imported calls without selector assertion panics or an invalid generated selector: diagnostics remain and unsafe fixes are omitted. S1037 now uses the exact time.After call matched by the pattern, so an unrelated nested After call cannot replace its package qualifier.
Added dot-import fixtures for all three checks and a nested unrelated After regression/golden fixture. Validation: go test ./simple/s1012 ./simple/s1024 ./simple/s1037 passed (seven tests); gofmt and git diff --check passed.