Repository navigation
Conversation
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a value appears multiple times in one CompositeValue, its referrer list contains that instruction once per operand. replaceAll previously rescanned every operand for every duplicate referrer, making replacement quadratic in the number of repeated operands.
Group adjacent occurrences of the same instruction and scan its operands once while preserving duplicate referrers on the replacement value. Add a focused correctness test and benchmark.
Hosted benchmark medians (2 CPU, 1 GiB container):
The 1024-operand case also drops from 12 allocations to 1.
Validation: full Linux, macOS, and Windows matrix on Go 1.26 and Go 1.27rc1, including go test, go vet, and Staticcheck.