8000 closing #6 formating of duration for table output. by KonstantinGasser · Pull Request #20 · dominikbraun/timetrace · GitHub
[go: up one dir, main page]
Skip to content

closing #6 formating of duration for table output. - #20

Merged
dominikbraun merged 1 commit into
dominikbraun:mainfrom
KonstantinGasser:#6-status-time-print-conventions
May 16, 2021
Merged

closing #6 formating of duration for table output.#20
dominikbraun merged 1 commit into
dominikbraun:mainfrom
KonstantinGasser:#6-status-time-print-conventions

Conversation

@KonstantinGasser
@KonstantinGasser KonstantinGasser commented May 16, 2021 •
edited
Loading
Copy link
Copy Markdown

Added two functions on the Report struct which format the duration according to the discussion in the issue. Both functions return the result of formatDuration which does the actual formatting. Tests of this function are included.

+-----------------+--------------------+--------------+
| CURRENT PROJECT | WORKED SINCE START | WORKED TODAY |
+-----------------+--------------------+--------------+
| timetest        | 0h 0min 5sec       | 1h 6min      |
+-----------------+--------------------+--------------+

And over one minute

+-----------------+--------------------+--------------+
| CURRENT PROJECT | WORKED SINCE START | WORKED TODAY |
+-----------------+--------------------+--------------+
| timetest        | 0h 1min            | 1h 7min      |
+-----------------+--------------------+--------------+

dominikbraun
dominikbraun approved these changes May 16, 2021
View reviewed changes
@dominikbraun dominikbraun left a comment
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice! And thanks for your test - this is still a ToDo within the codebase.

LGTM

@dominikbraun
dominikbraun merged commit 4efb25f into dominikbraun:main May 16, 2021
@KonstantinGasser
KonstantinGasser commented May 16, 2021
Copy link
Copy Markdown
Author

Thanks for the feedback - I appreciate it 😃! Let's open an Issue for tests? As I am getting more familiar with the code base I would be happy to write some more tests.

@dominikbraun
dominikbraun commented May 16, 2021
Copy link
Copy Markdown
Owner

Yes, we could even open an issue per package and create PRs package-wise.

@dominikbraun dominikbraun mentioned this pull request May 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dominikbraun dominikbraun dominikbraun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KonstantinGasser @dominikbraun
0